Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mc_att_control move most orb subscriptions to uORB::Subscription #12120

Merged
merged 1 commit into from
Jun 6, 2019
Merged

mc_att_control move most orb subscriptions to uORB::Subscription #12120

merged 1 commit into from
Jun 6, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented May 30, 2019

Requires #12040 before merging.

@dagar dagar added this to the Release v1.10.0 milestone May 30, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 2, 2019
Closed
@dagar dagar force-pushed the pr-mc_att_subscription branch from 99297cd to b3022ce Compare June 3, 2019 21:45
@dagar dagar force-pushed the pr-mc_att_subscription branch from b3022ce to b1d772f Compare June 3, 2019 21:52
@dagar dagar marked this pull request as ready for review June 3, 2019 21:52
@dagar
Copy link
Member Author

dagar commented Jun 3, 2019

Ready for review and testing. @MaEtUgR could you take a quick look?

@dagar dagar requested review from MaEtUgR and a team June 3, 2019 21:52
@jorge789
Copy link

jorge789 commented Jun 4, 2019

Tested on Pixhawk 2 Cube V3:

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

- Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

  • Notes
    No issues noted, good flight in general.

Logs
https://review.px4.io/plot_app?log=53707ac4-2b4f-4f3b-8e0e-7e8d4c49c69f

https://review.px4.io/plot_app?log=69f30a2c-4ac0-4118-bcbd-e4fd8e9a5041

@jorge789
Copy link

jorge789 commented Jun 5, 2019

Tested on Pixhawk 4 V5

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

- Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes
No issues noted, good flight in general.

Logs

https://review.px4.io/plot_app?log=97cf0c2e-8f2f-4871-b4fb-f2e4fab1b069

https://review.px4.io/plot_app?log=67aa133f-3d14-4418-bd37-5fddce835703

COMPARISON OF MASTER :
https://review.px4.io/plot_app?log=b2757ff6-ba4e-46bd-8844-76665aee3ea9

@Tony3dr Tony3dr mentioned this pull request Jun 5, 2019
Closed
@dagar dagar merged commit 4c42cac into PX4:master Jun 6, 2019
@dagar dagar deleted the pr-mc_att_subscription branch June 6, 2019 00:37
@dagar dagar mentioned this pull request Jun 6, 2019
Merged
@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaEtUgR MaEtUgR Awaiting requested review from MaEtUgR

Assignees
No one assigned
Labels
Admin: Cleanup (housekeeping) 🧹 Admin: Enhancement (improvement) 💡 Multirotor 🛸
Projects
None yet
Milestone
Release v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @jorge789